Skip to content

refactor: methods and improve type hints #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julien-nc merged 1 commit into from
Feb 3, 2026
Merged

refactor: methods and improve type hints #1320

julien-nc merged 1 commit into from
Feb 3, 2026

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Feb 2, 2026

Refactored method

  • Inverted logic: Used try-catch pattern instead of pre-checking if provider exists
  • More natural flow: Update case (most common) comes first, create case in catch block

@solracsf
refactor: methods and improve type hints
8fb3ed5 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf marked this pull request as ready for review February 2, 2026 10:14
@julien-nc julien-nc merged commit 72d9c5e into main Feb 3, 2026
38 checks passed
@julien-nc julien-nc deleted the methodsTypeHints branch February 3, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-nc julien-nc julien-nc approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@solracsf @julien-nc