refactor: readonly class feature

lib/Model/Token.php

@@ -1,6 +1,7 @@
 <?php
 
 declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
@@ -12,30 +13,30 @@
 
 class Token implements JsonSerializable {
 
-	private ?string $idToken;
-	private string $accessToken;
-	private int $expiresIn;
-	private ?int $refreshExpiresIn;
-	private ?string $refreshToken;
-	private int $createdAt;
-	private ?int $providerId;
+	private readonly ?string $idToken;
+	private readonly string $accessToken;
+	private readonly int $expiresIn;
+	private readonly ?int $refreshExpiresIn;
+	private readonly ?string $refreshToken;
+	private readonly int $createdAt;
+	private readonly ?int $providerId;
 
 	public function __construct(array $tokenData) {
 		$this->idToken = $tokenData['id_token'] ?? null;
 		$this->accessToken = $tokenData['access_token'];
 		$this->expiresIn = $tokenData['expires_in'];
 		$this->refreshExpiresIn = $tokenData['refresh_expires_in'] ?? null;
 		$this->refreshToken = $tokenData['refresh_token'] ?? null;
 		$this->createdAt = $tokenData['created_at'] ?? time();
 		$this->providerId = $tokenData['provider_id'] ?? null;
 	}
 
 	public function getAccessToken(): string {
 		return $this->accessToken;
 	}
 
 	public function getIdToken(): ?string {
 		return $this->idToken;
 	}
 
 	public function getExpiresIn(): int {
@@ -43,8 +44,7 @@
 	}
 
 	public function getExpiresInFromNow(): int {
-		$expiresAt = $this->createdAt + $this->expiresIn;
-		return $expiresAt - time();
+		return ($this->createdAt + $this->expiresIn) - time();
 	}
 
 	public function getRefreshExpiresIn(): ?int {
@@ -53,12 +53,10 @@
 
 	public function getRefreshExpiresInFromNow(): int {
 		// if there is no refresh_expires_in, we assume the refresh token never expires
-		// so we don't need getRefreshExpiresInFromNow
 		if ($this->refreshExpiresIn === null) {
 			return 0;
 		}
-		$refreshExpiresAt = $this->createdAt + $this->refreshExpiresIn;
-		return $refreshExpiresAt - time();
+		return ($this->createdAt + $this->refreshExpiresIn) - time();
 	}
 
 	public function getRefreshToken(): ?string {
@@ -93,7 +91,7 @@
 		return time() > ($this->createdAt + (int)($this->refreshExpiresIn / 2));
 	}
 
-	public function getCreatedAt() {
+	public function getCreatedAt(): int {
 		return $this->createdAt;
 	}