Skip to content

Add test samplesheets for samplesheetparser modules#2013

Open
chaitanyakasaraneni wants to merge 1 commit intonf-core:modulesfrom
chaitanyakasaraneni:add-samplesheetparser-testdata
Open

Add test samplesheets for samplesheetparser modules#2013
chaitanyakasaraneni wants to merge 1 commit intonf-core:modulesfrom
chaitanyakasaraneni:add-samplesheetparser-testdata

Conversation

@chaitanyakasaraneni
Copy link
Copy Markdown

Adds two minimal Illumina SampleSheet.csv fixtures under data/generic/csv/samplesheets/ to back seven new samplesheetparser/* modules being contributed to nf-core/modules (companion PRs to follow).

Files added

  • samplesheet.v1.csv — IEM V1 (bcl2fastq) format, dual-index, 5 samples across 2 projects and 2 lanes (957 B)
  • samplesheet.v2.csv — BCLConvert V2 format, dual-index, 5 samples across 2 projects and 2 lanes (670 B)
  • README.md has been updated to list them under the generic/csv section.

@maxulysse
Copy link
Copy Markdown
Member

That looks interesting.
where are these samplesheetparser modules?

@matthdsm
Copy link
Copy Markdown

Is there any way you could use or amend the existing samplesheet in the test data repo? -> genomics/homo_sapiens/illumina/bcl/flowcell_samplesheet.csv

Perhaps add a V1 and V2 version of that one (and make sure not to break any modules tests in the process)

@chaitanyakasaraneni
Copy link
Copy Markdown
Author

That looks interesting. where are these samplesheetparser modules?

Hey @maxulysse! Thanks for the interest! The samplesheetparser/* modules are still in local testing. I'll open the PRs against nf-core/modules once this test-datasets PR lands.

In the meantime, if you'd like to try the underlying tool:

@chaitanyakasaraneni chaitanyakasaraneni force-pushed the add-samplesheetparser-testdata branch from 659f3f7 to 1977568 Compare April 24, 2026 12:09
@chaitanyakasaraneni
Copy link
Copy Markdown
Author

Is there any way you could use or amend the existing samplesheet in the test data repo? -> genomics/homo_sapiens/illumina/bcl/flowcell_samplesheet.csv

Perhaps add a V1 and V2 version of that one (and make sure not to break any modules tests in the process)

Hey @matthdsm! Thanks for the suggestion! I moved the fixtures into data/genomics/homo_sapiens/illumina/bcl/ as siblings to the existing flowcell_samplesheet.csv (named flowcell_samplesheet.v1.csv and flowcell_samplesheet.v2.csv). The existing file and its consumers (bcl2fastq, bclconvert, bcl_demultiplex) remain untouched. Updated the README next to the existing entry and pushed the amended commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants