Following symlinks when docker-entrypoint.sh starts.#731
Open
walkure wants to merge 1 commit intonginx:masterfrom
Open
Following symlinks when docker-entrypoint.sh starts.#731walkure wants to merge 1 commit intonginx:masterfrom
walkure wants to merge 1 commit intonginx:masterfrom
Conversation
|
I also have issue related whit this. I use image in kubernetes and mount Config into And command: However command: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some k8s implentations (I use k0s v1.25.2+k0s.0) use symlinks when mounting ConfigMap as volume.
Following
findsupports symbolic linked contents. But the firstfinddoes not follow symlinks, it is not processed.https://github.com/nginxinc/docker-nginx/blob/5ce65c3efd395ee2d82d32670f233140e92dba99/entrypoint/docker-entrypoint.sh#L17
Since
find(L17) includes dotdirs when following symlinks, found shell scripts are evaluated multiple times (at my environment.).Excluding dotdirs(like below) will resolve it , but I'm afraid of breaking backward compatibility.