Expose cleanup function as public#20
Open
yancouto wants to merge 2 commits intonickbrowne:masterfrom
yancouto:master
Open
Expose cleanup function as public#20yancouto wants to merge 2 commits intonickbrowne:masterfrom yancouto:master
yancouto wants to merge 2 commits intonickbrowne:masterfrom
yancouto:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes a
cleanupfunction as public (similar to the presentinitfunctions), which allows cleaning up early.This makes stuff more customisable. In my game that uses bracket-lib, using the normal cleanup (which uses
libc::atexit) makes the window hang when it's closing, for some reason, so I use this change to do the cleanup early and not leave the screen hanging.