fix: copy code-server failed on second launch - #105
Open
whn-hjm wants to merge 1 commit into
Open
Conversation
Fix two bugs causing '拷贝code-server失败' (copy code-server failed) on subsequent app launches: 1. Missing await on loadCodeVersion() caused a race condition with permission request and code-server version reading (line 205). 2. Custom code-server path: targetFile.lengthSync() threw when file didn't exist, and copy() always executed even after skip log due to missing if-else guard (lines 237-249). Closes nightmare-space#96 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two bugs causing '拷贝code-server失败' (copy code-server failed) on subsequent app launches:
Missing await on loadCodeVersion() caused a race condition with permission request and code-server version reading (line 205).
Custom code-server path: targetFile.lengthSync() threw when file didn't exist, and copy() always executed even after skip log due to missing if-else guard (lines 237-249).
Closes #96