Conversation
|
@nigoroll just a follow up questions on this design: from my reading on SRV records, it should already contain the priority and weight per entry. so I would assume that anyone using SRV records with so the point of this proposal is to mimick the way that SRV records are designed but bring the concept to A/AAAA/CNAME records, right? |
Owner
Author
Exactly that, with the intend of improving code reuse / avoid duplication, while also implementing a proven concept. |
sounds alright to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft of an idea to generalize #138, implementing #132
As of this initial comment, there is no implementation, just a proposed VCC interface.
My expectation would be that this should allow to share code with the existing service implementation (which queries SRV records), because the resulting structure should be identical.
Copying the central example from the VCC draft, this would implement:
as a shorthand of
with
.add()allowing for fine grained control, enabling other use cases, like preferring a local datacenter over a remote one.Note that the proposal also includes support for the weight attribute, such that multiple A/AAAA/CNAME records can be added for load balancing.