ci: static checks and the Python suites on every push - #13
Merged
Merged
Conversation
The README action tables can fall behind the [CommandAction] declarations without anyone noticing -- #12 added ten rows that had been missing for some time. A tracked file arriving without its .meta has the same shape: nothing complains until someone imports the package. Both are decidable from the tree alone, so they run on every push. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The client under Editor/ExternalTool~/console-client has 243 tests, and its own .gitignore excluded the whole tests/ directory. The two commands the contributor guide names could therefore only be run by someone who already had the files, and nothing verified the shared core that the external CLI loads through this package. Unity never imports a ~ suffixed directory, so the suites add 229 KB to the package and nothing to a consuming project. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits, separable.
Static checks without Unity (
.github/scripts/check_package.py):[CommandAction]declarations — every declarednamespace/actionmust appear in bothREADME.mdandREADME_zh.md, nothing undeclared may appear, and the count sentence above each table must match. List every built-in action in the README tables #12 added ten rows that had silently gone missing; this makes that drift a red build instead..metacompleteness — every tracked path Unity would import needs its.meta, and no.metamay point at nothing. 92 imported paths today.Verified by seven injected regressions (missing row, stale count, ghost action, undocumented action, duplicate id, missing
.meta, orphan.meta) — each turns the check red; the clean tree is green.Track and run the Python suites:
Editor/ExternalTool~/console-client/.gitignoreexcluded the wholetests/directory, so the 243 tests behind the two documented test commands were never in version control — including the cross-language check that readsCommandRouter.csto pin the command protocol. Unity never imports a~directory, so this adds 229 KB to the package and nothing to a consuming project.Whole workflow verified on a clean clone with a fresh venv: static checks pass, core suite 35 OK, REPL suite 208 OK.
🤖 Generated with Claude Code