Skip to content

let user pass extra attributes#16

Open
hosmelq wants to merge 3 commits into
nitish24p:masterfrom
hosmelq:master
Open

let user pass extra attributes#16
hosmelq wants to merge 3 commits into
nitish24p:masterfrom
hosmelq:master

Conversation

@hosmelq

@hosmelq hosmelq commented Feb 13, 2018

Copy link
Copy Markdown

No description provided.

@nitish24p

Copy link
Copy Markdown
Owner

can you put forth a use case?

@hosmelq

hosmelq commented Feb 13, 2018

Copy link
Copy Markdown
Author

@nitish24p if you need to pass any other attribute to <img /> you can not.

For example, I need to pass custom alt and aria attributes.

@manjula-dube

Copy link
Copy Markdown
Collaborator

So you want to have a support to pass alt and aria attributes as props Right?

@kurtextrem

Copy link
Copy Markdown
Contributor

This is a nice PR, as it allows every prop a user wants. For example height, width and the new decoding as well. (Decoding ref is here: https://html.spec.whatwg.org/multipage/images.html#image-decoding-hint - afaik only Chrome implemented it yet)

@hosmelq

hosmelq commented Feb 14, 2018

Copy link
Copy Markdown
Author

Yes @manjula91 and any other attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants