Skip to content

fix: preserve sourcemap mappings for chunks containing user code - #4450

Merged
pi0 merged 4 commits into
nitrojs:v2from
danielroe:fix/backport-sourcemap-min
Jul 21, 2026
Merged

fix: preserve sourcemap mappings for chunks containing user code#4450
pi0 merged 4 commits into
nitrojs:v2from
danielroe:fix/backport-sourcemap-min

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/nuxt#35680
nuxt/nuxt#24414

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

this backports #4031 to v2

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Co-authored-by: Abdelrahman Awad <me@awad.dev>
@danielroe
danielroe requested a review from pi0 as a code owner July 19, 2026 23:10
@vercel

vercel Bot commented Jul 19, 2026

Copy link
Copy Markdown

@danielroe is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b4d3de5c-7475-490e-981b-3a4515fd3d02

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/nitropack@4450

commit: ce144c1

@pi0 pi0 added the v2 label Jul 21, 2026
@pi0

pi0 commented Jul 21, 2026

Copy link
Copy Markdown
Member

can you please check type issue

@pi0
pi0 merged commit e9b256d into nitrojs:v2 Jul 21, 2026
7 of 8 checks passed
@danielroe
danielroe deleted the fix/backport-sourcemap-min branch July 21, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants