fix(vercel): prevent caching missing public assets - #4474
Conversation
|
@ryoid is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Vercel preset now generates escaped public-asset route patterns, caches existing immutable assets, and returns uncached 404 responses for missing assets after filesystem handling. Tests update the route snapshot and verify the generated 404 rule. ChangesVercel public asset routing
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Linked issue
Fixes #4427
❓ Type of change
📚 Description
This adds a
no-store404 after the filesystem check so missing assets don't fall through with immutable caching.This follows the same approach as SvelteKit.
📝 Checklist