fix: try to resolve server entry also from server/index - #4478
Conversation
|
@lazerg is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughServer entry auto-detection now considers both ChangesServer entry detection
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/unit/server-entry.test.ts`:
- Line 3: Update the path assertions in the server entry tests to normalize the
resolved handler path before comparison, using the existing pathe utilities or
an equivalent separator-independent matcher. Apply this to the assertions around
both the referenced import and the additional lines 43–49, while preserving the
expected path values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a68822b1-4281-4e99-99a5-a5e5b8bd52d5
📒 Files selected for processing (2)
src/config/resolvers/paths.tstest/unit/server-entry.test.ts
server/index
🔗 Linked issue
Resolves #4455
❓ Type of change
📚 Description
server.tsin the project root is auto-detected as the server entry, and #4313 extended that to aserverdir, butserver/index.tsstill isn't picked up. This addsindexto the resolved suffixes so the folder form (server/index.ts) is detected the same way.📝 Checklist