Maintenance and performance tweaks#2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
nitro-dispatchplugin system to version 1.1.0, introducing several improvements and fixes. The most significant changes include stricter wildcard event matching, enhanced decorator safety, and improved plugin discovery and registration. Documentation and type annotations have also been clarified throughout the codebase.Event Matching Improvements:
user.*matchesuser.loginbut notuser.profile.update), providing more predictable and precise event handling. [1] [2]Decorator Safety and Testing:
@hookdecorator now raises aTypeErrorif stacked on the same method, preventing accidental multiple event subscriptions for a single handler. A corresponding test ensures this behavior. [1] [2]Plugin Manager Enhancements:
PluginManager.registermethod now returns the plugin's name, and plugin discovery uses this return value for accurate tracking. This change also avoids unnecessary instantiation of plugins during reloads, improving efficiency and correctness. [1] [2] [3] [4] [5] [6]Documentation and Typing Updates:
Version Bump:
1.0.2to1.1.0in both__init__.pyandpyproject.toml. [1] [2]