Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions CI/CD pipeline for this devcontainer features repo by chaining workflows so validation runs first, then tests, then publishing.
Changes:
- Rename workflows to
Devcontainer validate,Devcontainer test, andDevcontainer publish. - Trigger tests via
workflow_runafter validation completes, with a gate job to decide whether to run. - Trigger publishing via
workflow_runafter tests complete onmain, with a gate job to decide whether to run.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/validate.yml | Renames validation workflow and changes triggers to run on push and pull_request. |
| .github/workflows/test.yaml | Switches tests to run on workflow_run after validation and adds a gating job. |
| .github/workflows/release.yaml | Switches publishing to run on workflow_run after tests on main and adds a gating job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: "Devcontainer validate" | ||
| on: | ||
| workflow_dispatch: | ||
| push: |
Comment on lines
38
to
41
| test-autogenerated: | ||
| needs: check-validate | ||
| if: needs.check-validate.outputs.should_run == 'true' | ||
| runs-on: ubuntu-latest |
Comment on lines
+1
to
6
| name: "Devcontainer test" | ||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| workflow_run: | ||
| workflows: ["Devcontainer validate"] | ||
| types: [completed] | ||
| workflow_dispatch: |
Comment on lines
27
to
30
| deploy: | ||
| if: ${{ github.ref == 'refs/heads/main' }} | ||
| needs: check-test | ||
| if: needs.check-test.outputs.should_run == 'true' && github.ref == 'refs/heads/main' | ||
| runs-on: ubuntu-latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.