feat(claude-code-review)!: default to a GitHub-hosted runner - #80
Merged
Merged
Conversation
The review job reads a PR diff and calls the Claude API. It needs no private-network access, no local toolchain and no persistent state, so a self-hosted runner buys it nothing -- while costing a great deal on a contended pool. Measured on the sproncy pool: the job queued 40-77 minutes to do 3-6 minutes of work, so reviews routinely posted after the PR had already merged, and it failed outright at runner assignment (zero steps executed) in roughly one run in six. Both are queueing artefacts rather than anything wrong with the review. Moving the default also returns capacity to the pool for the jobs that do need a real machine -- heavy test suites with service containers and local toolchains. BREAKING: changes behaviour for every consumer that does not pass runs-on explicitly, which is currently all but sproncy/monitoring_stack. Those wanting the old behaviour pass runs-on: \x27["self-hosted", "linux", "x64"]\x27. Pinned to a dated image rather than ubuntu-latest so a GitHub-side image bump is an intentional, reviewable change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0114gaSKj6YinQCkmxVbDACv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the review job's queueing and its ~1-in-6 hard failures — one change here instead of 27 consumer PRs.
The problem, measured
The review job reads a PR diff and calls the Claude API. It needs no private-network access, no local toolchain and no persistent state — so a self-hosted runner buys it nothing. On a contended pool it cost a lot:
Two consequences, both observed repeatedly:
conclusion=failurewithsteps_run=0, dying at runner assignment. Across three sampled repos:failure=1 success=5each.Both are queueing artefacts. Neither is a problem with the review.
Why the default, not per-repo
27 repos consume this workflow. 26 pass no
runs-onat all and inherit the default here; onlysproncy/monitoring_stacksets it explicitly. Changing the default fixes all 26 at once and leaves the one deliberate opt-out untouched.This changes behaviour for every consumer that does not pass
runs-on— currently all butmonitoring_stack. The escape hatch is unchanged: passruns-on: '["self-hosted", "linux", "x64"]'.Consumers pin
@v3, andv3currently points atmain(97080ab). Nothing reaches them until thev3tag is re-pointed at the release containing this commit — worth being deliberate about, given the blast radius.Hosted minutes are metered on private repos. A review is 3–6 minutes. For context,
sproncyis at 653 of 2,000 for September andHordiaLabsat 315, so there is room — but this moves real volume onto that meter across every consuming org.The image is pinned to
ubuntu-24.04rather thanubuntu-latestso a GitHub-side image bump is an intentional, reviewable change rather than a silent environment shift.🤖 Generated with Claude Code
https://claude.ai/code/session_0114gaSKj6YinQCkmxVbDACv