Conversation
Two faults found while clearing red mains across the HordiaLabs consumers. setup-qemu-action ran unconditionally. QEMU exists only to emulate a foreign architecture, the runners are all X64, and `platforms` defaults to linux/amd64 -- so for most consumers the step installed binfmt handlers that nothing then used. It cost 16m18s on one observed extractor-llm run, ahead of a build that never needed it, on a three-runner pool where queueing is the dominant cost. Now skipped when `platforms` is exactly linux/amd64. The two consumers that really cross-build, scraper-proxy-router always and store-s3 on main, request linux/arm64 and still get it. The SARIF upload had no opt-out. trivy-repo.yml has carried an `upload-sarif` input for exactly this since the Free-plan private repos cannot use code scanning, but docker-build.yml uploaded unconditionally, so `Upload SARIF` failed with "Advanced Security must be enabled for this repository to use code scanning" on every push to main while the Trivy scan immediately above it passed. A permanently red check reporting an entitlement rather than a finding. Adds the matching input, defaulting true so nothing changes for consumers that do have Advanced Security, and gates the SARIF generation step on it too so nothing is produced that cannot be uploaded. Affects the two consumers that pass `run-trivy-scan: true`, extractor-llm and store-postgres; both need `upload-sarif: false` once this is released. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EoicTZniGXry3W7YFZBsSM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two faults found while clearing red mains across the HordiaLabs consumers.
setup-qemu-action ran unconditionally. QEMU exists only to emulate a foreign
architecture, the runners are all X64, and
platformsdefaults to linux/amd64 --so for most consumers the step installed binfmt handlers that nothing then used.
It cost 16m18s on one observed extractor-llm run, ahead of a build that never
needed it, on a three-runner pool where queueing is the dominant cost. Now
skipped when
platformsis exactly linux/amd64. The two consumers that reallycross-build, scraper-proxy-router always and store-s3 on main, request
linux/arm64 and still get it.
The SARIF upload had no opt-out. trivy-repo.yml has carried an
upload-sarifinput for exactly this since the Free-plan private repos cannot use code
scanning, but docker-build.yml uploaded unconditionally, so
Upload SARIFfailed with "Advanced Security must be enabled for this repository to use code
scanning" on every push to main while the Trivy scan immediately above it
passed. A permanently red check reporting an entitlement rather than a finding.
Adds the matching input, defaulting true so nothing changes for consumers that
do have Advanced Security, and gates the SARIF generation step on it too so
nothing is produced that cannot be uploaded.
Affects the two consumers that pass
run-trivy-scan: true, extractor-llm andstore-postgres; both need
upload-sarif: falseonce this is released.Test plan
actionlint .github/workflows/*.ymlpasses.scraper-proxy-router(linux/amd64,linux/arm64) andstore-s3(linux/amd64,linux/arm64on main,linux/amd64otherwise) request a non-native platform, and both still match the condition.true, so this is a no-op for consumers that do not pass it.🤖 Generated with Claude Code
https://claude.ai/code/session_01EoicTZniGXry3W7YFZBsSM