test(terminal): add cell-grid verification via libghostty-vt#383
Open
test(terminal): add cell-grid verification via libghostty-vt#383
Conversation
Parse converter output through the real Ghostty VT emulator and assert on the rendered cell grid (char, bold/italic, OSC 8 hyperlink) instead of diffing raw ANSI byte streams. This layer survives harmless SGR reorderings and actually exercises the rendering pipeline a terminal user experiences, catching bugs where the bytes look right but would render wrong. The existing fixture-based integration tests are kept as-is; this is additive. Tests live in converters/terminal/tests/grid_test.rs and cover section headers, paragraphs, bold/italic inline formatting, ordered/unordered lists, NOTE and WARNING admonitions, tables, source blocks, and OSC 8 hyperlink attribution (both with the capability forced on and off). - Adds libghostty-vt 0.1.1 as a dev-dependency of the terminal crate. - Adds Processor::with_capabilities() so tests can force OSC 8 on regardless of the host TERM environment (mirrors the existing with_terminal_width() builder pattern). - Installs Zig 0.15.1 via mlugg/setup-zig in the test-converters, clippy, and doctest CI jobs, which are the jobs that compile the dev-dependency through --all-targets / --doc. - Updates acdc-converters-terminal CHANGELOG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse converter output through the real Ghostty VT emulator and assert
on the rendered cell grid (char, bold/italic, OSC 8 hyperlink) instead
of diffing raw ANSI byte streams. This layer survives harmless SGR
reorderings and actually exercises the rendering pipeline a terminal
user experiences, catching bugs where the bytes look right but would
render wrong.
The existing fixture-based integration tests are kept as-is; this is
additive. Tests live in converters/terminal/tests/grid_test.rs and
cover section headers, paragraphs, bold/italic inline formatting,
ordered/unordered lists, NOTE and WARNING admonitions, tables,
source blocks, and OSC 8 hyperlink attribution (both with the
capability forced on and off).
regardless of the host TERM environment (mirrors the existing
with_terminal_width() builder pattern).
clippy, and doctest CI jobs, which are the jobs that compile the
dev-dependency through --all-targets / --doc.