Conversation
|
Here are the artifacts from your PR: |
|
I agree with Ian that this section needs an intro paragraph and to address the suggestions in #326. I can work on this after I do the vignette associated with nmfs-ost/ss3-source-code#747 |
|
@Rick-Methot-NOAA, yes it does |
iantaylor-NOAA
left a comment
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
@e-perl-NOAA, thanks for working on this. The changes are all valuable improvements, but I think that adding an intro paragraph thanks to @Rick-Methot-NOAA is also needed.
I would also include a table similar to the one pasted below for selectivity after that intro paragraph, prior to the von Bertalanffy description instead of just relying on hyperlinks in the "Example growth specifications" section which comes later (although the hyperlinks are still a valuable addition there).
|
|
||
| \multicolumn{2}{l}{COND if growth type >= 3} & Age-Specific K \\ | ||
| & \multicolumn{2}{l}{N parameter lines equal to the number K deviations for the ages specified above.} \Bstrut\\ | ||
| \hypertarget{RichardsLine}{Richards Coefficient} & \multicolumn{2}{l}{Only include this parameter if Richards growth function is used. If included, a parameter value of 1.0 will have a null effect and produce a growth curve identical to von Bertalanffy. To use the Gompertz growth curve, the Richards parameter can be fixed at a small value such as 0.0001.} \\ |
There was a problem hiding this comment.
formatting of this section is not very good in the PDF version of the manual. Maybe this information just isn't well suited to the table format of "Read Biology Parameters" and should come after?
|
Here are the artifacts from your PR: |
|
Here are the artifacts from your PR: |
|
Here are the artifacts from your PR: |
|
I just took a look at the changes to the user manual. The growth section is now much easier to understand and follow. Nice work @e-perl-NOAA and @Rick-Methot-NOAA! A few trivial issues, that @e-perl-NOAA may already be working on are
|
|
Here are the artifacts from your PR: |
|
Yes, I'm working on these things, it's slow as it's only during breaks while I'm virtually attending the Improving Scientific Software conference this week |
I should have just assumed you were on top of fixing this stuff. Thank you, and enjoy the conference! |
|
Here are the artifacts from your PR: |
|
Here are the artifacts from your PR: |
|
huge improvement. Bravo team |
|
Here are the artifacts from your PR: |
3 participants
This attempts to better link the growth sections with each other and provide more detail in setting up the different growth parameters.
Resolves #326