Skip to content

Bug fixes id'd from workshop#231

Merged
Schiano-NOAA merged 8 commits intomainfrom
dev
Apr 15, 2026
Merged

Bug fixes id'd from workshop#231
Schiano-NOAA merged 8 commits intomainfrom
dev

Conversation

@Schiano-NOAA
Copy link
Copy Markdown
Collaborator

Variety of bug fixes that were identified during the workshop or by FIMS devs

Schiano-NOAA and others added 7 commits April 6, 2026 16:41
* add in optional ggplot args

* adjust process data so grouping is correctly adjusted based on model condition and grouping

* change default model as 1 from NA

* set plot to look for only recruitment and not rec exp or obs

* allow users to access ggplot geom args

* fix maggritr in pipe
* initial commit of new obs v pred plot

* adjust process data so it converts all indexed data to character to function even when input values are numeric per #212

* update plot indices to use new plot_obsvpred function and adjust based on needs

* update documentation for package

* adjust plot_indices where nfleet = 1 and update test to remove new file produced

* add missing dependency
… from SS3 (#222)

* adjust reference line to take our era and use plot data instead

* adjust reference label to replace underscore with space

* update ref line documentation

* fix commit from overwrite when rebasing

* fixes to plot including adjusting missing legend

* add back in ggplot options

* adjust plot ts to stop error from color label

* adjust conditions where legend is remove
…anges (#229)

* Initial plan

* Add GitHub Action to update example_data when convert_output.R changes

Agent-Logs-Url: https://github.com/nmfs-ost/stockplotr/sessions/16147f90-2416-4af0-a517-a1d297703e33

Co-authored-by: Schiano-NOAA <125507018+Schiano-NOAA@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Schiano-NOAA <125507018+Schiano-NOAA@users.noreply.github.com>
#227)

* Address most suggestions as per #198

* Add details section

* Update documentation
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

New version checklist

  • Package version in DESCRIPTION has been updated
  • Release notes have been drafted/published
  • Cheatsheet content has been updated (if applicable)
  • Cheatsheet version has been updated

Comment thread .github/workflows/update-example-data.yml Dismissed
Comment thread .github/workflows/update-example-data.yml Dismissed
@github-actions
Copy link
Copy Markdown
Contributor

Code Metrics Report

Coverage Code to Test Ratio Test Execution Time
69.5% 1:0.2 4m36s

Code coverage of files in pull request scope (76.9%)

Files Coverage
R/plot_fishing_mortality.R 84.0%
R/plot_indices.R 90.1%
R/plot_recruitment.R 68.9%
R/plot_recruitment_deviations.R 76.8%
R/plot_spawning_biomass.R 83.3%
R/process_data.R 56.9%
R/utils_plot.R 85.2%

Reported by octocov

@Schiano-NOAA Schiano-NOAA marked this pull request as ready for review April 15, 2026 21:26
@Schiano-NOAA Schiano-NOAA merged commit 154d903 into main Apr 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants