ansible: update gn and ninja for V8 builds#4233
Open
richardlau wants to merge 1 commit intonodejs:mainfrom
Open
ansible: update gn and ninja for V8 builds#4233richardlau wants to merge 1 commit intonodejs:mainfrom
richardlau wants to merge 1 commit intonodejs:mainfrom
Conversation
Update the versions of `gn` and `ninja` used in the V8 CI for Linux on ppc64le and s390x.
Member
Author
|
I've deployed these changes on the rhel8-ppc64le and rhel8-s390x machines. For the V8 14.5 update PR: https://ci.nodejs.org/job/node-test-commit-v8-linux/7010/ rhel8-s390x is now passing 🎉. Getting Power 9 based machines into the CI is on IBM's list of things to do before Node.js 26 -- I'll look at that next. |
Member
|
This might not be very near, but as an FYI, V8 might stop supporting ninja one day and fully switch to siso https://groups.google.com/a/chromium.org/g/chromium-dev/c/v-WOvWUtOpg |
Member
Author
Thanks. We were previously aware of https://issues.chromium.org/issues/42204582. FYI @miladfarca @abmusse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the versions of
gnandninjaused in the V8 CI for Linux on ppc64le and s390x.Refs: nodejs/node#61681 (comment)
For V8 14.5,
gnneeds to be updated to pick upstring_hashwhich was introduced in https://gn.googlesource.com/gn/+/ab6f8b2124b02000f5ffcabb904622f17de6a1e5 (I've updated to use the current HEAD https://gn.googlesource.com/gn/+/304bbef6c7e9a86630c12986b99c8654eb7fe648).https://ci.nodejs.org/job/node-test-commit-v8-linux/7006/nodes=rhel8-ppc64le,v8test=v8test/console
ninjaneeds to be updated to fix this error:https://ci.nodejs.org/job/node-test-commit-v8-linux/7008/nodes=rhel8-ppc64le,v8test=v8test/console
Since the packaged version of
ninja-buildon RHEL 8 is too old, we compileninjafrom source.