Skip to content

ansible: add alpine/musl builds to expected assets - #4428

Open
sxa wants to merge 2 commits into
nodejs:mainfrom
sxa:alpine_assets
Open

ansible: add alpine/musl builds to expected assets#4428
sxa wants to merge 2 commits into
nodejs:mainfrom
sxa:alpine_assets

Conversation

@sxa

@sxa sxa commented Aug 13, 2026

Copy link
Copy Markdown
Member

Part of the process for adding Alpine into the release builds.
Does the merging of this have to be explicitly co-ordinated with the addition to iojs+release?

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa
sxa requested a review from richardlau August 13, 2026 16:42
@sxa sxa self-assigned this Aug 13, 2026
@sxa sxa mentioned this pull request Aug 13, 2026
8 tasks
@richardlau

Copy link
Copy Markdown
Member

Part of the process for adding Alpine into the release builds. Does the merging of this have to be explicitly co-ordinated with the addition to iojs+release?

It needs to happen before any release that would include the additional assets. If it doesn't releasers would need to bypass the warning from the promotion script about extra unexpected assets.

@sxa

sxa commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

Part of the process for adding Alpine into the release builds. Does the merging of this have to be explicitly co-ordinated with the addition to iojs+release?

It needs to happen before any release that would include the additional assets. If it doesn't releasers would need to bypass the warning from the promotion script about extra unexpected assets.

OK - so wouldn't affect the nightlies and other non-release builds - only when release promotion occurs.

@sxa

sxa commented Aug 14, 2026

Copy link
Copy Markdown
Member Author

Putting back into draft pending nodejs/node#65282 being merged back into the release lines

@sxa
sxa marked this pull request as draft August 14, 2026 13:08
@sxa
sxa marked this pull request as ready for review August 18, 2026 14:55
@sxa

sxa commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

The checks are failing but it looks like it's checking older releases which won't have the artifacts. It's also complaining about foo.tar.gz and bar.tar.xz

          ⚠  The following assets are expected for v22.x but are currently missing from R2 staging:
            • node-v22.12.0-linux-x64-musl.tar.gz
            • node-v22.12.0-linux-x64-musl.tar.xz
         ✖  The following assets were already promoted in R2 but are not expected for v22.x:
            • foo.tar.gz
            • bar.tar.xz

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa
sxa force-pushed the alpine_assets branch 2 times, most recently from a46e1d7 to 97ebaa7 Compare August 18, 2026 17:50
@sxa

sxa commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

I feel it's better to skip the v22.x change temporarily for now, otherwise there will be a lot of updating of the tests to handle the "unexpected" missing alpine changes which will make most of the testing completely pointless. Perhaps once we've done one release with Alpine we can modify the tests to use a newer release and have the expected numbers and do the changes for v22.x. Should be ok as long as we do one release on 26 or 24 before 22.

@sxa
sxa requested a review from richardlau August 18, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants