Conversation
Member
|
Does it create a single header.zip file and upload it into the github release like ada, simdutf, simdjson? |
Collaborator
Author
|
Yes, at least it's supposed to: https://github.com/anonrig/merve/blob/f0f5fa8bb9c044820061761eee5aeed52e692c53/.github/workflows/release.yml#L53 |
Collaborator
Author
|
I might have forgotten to pass the token, wait |
aduh95
commented
Jan 28, 2026
anonrig
reviewed
Jan 28, 2026
anonrig
reviewed
Jan 28, 2026
| run: ./tools/release/create_release.py | ||
| run: gh release upload "$RELEASE_TAG" singleheader/* | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} |
Member
There was a problem hiding this comment.
I'll enable immutable releases and see if this properly creates the release or not. (Once it lands)
Ref: https://docs.github.com/en/code-security/concepts/supply-chain-security/immutable-releases
anonrig
approved these changes
Jan 28, 2026
Member
|
@aduh95 Can you rebase? |
aduh95
force-pushed
the
release-please
branch
from
d80de8f to
150cc47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the need to maintain the custom Python script, and is consistent with how releases are done in many other nodejs repos.