util: refactor filterDuplicateStrings for readability#60347
Open
Ayoub-Mabrouk wants to merge 1 commit intonodejs:mainfrom
Open
util: refactor filterDuplicateStrings for readability#60347Ayoub-Mabrouk wants to merge 1 commit intonodejs:mainfrom
Ayoub-Mabrouk wants to merge 1 commit intonodejs:mainfrom
Conversation
Modernize filterDuplicateStrings by using for-of loop and ternary operator for cleaner, more idiomatic ES2018 code. Changes: - Replace traditional for loop with for-of iteration - Consolidate conditional map.set() using ternary operator - Eliminate iterator variable reducing cognitive complexity No functional changes, performance remains equivalent.
nodejs-github-bot
added
needs-ci
|
Hi @Ayoub-Mabrouk as I know, the Node.js team is trying to avoid the |
Author
Thanks alot 🙏👌 |
Member
|
for-of is much slower than a for loop. |
Author
Thanks for the feedback |
Contributor
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize filterDuplicateStrings by using for-of loop and ternary
operator for cleaner, more idiomatic ES2018 code.
Changes:
No functional changes, performance remains equivalent.