Skip to content

test: avoid flaky debugger restart waits #61773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inoway46 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

test: avoid flaky debugger restart waits #61773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/parallel/test-debugger-restart-message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ const startCLI = require('../common/debugger');
assert.strictEqual(cli.output.match(listeningRegExp).length, 1);

for (let i = 0; i < RESTARTS; i++) {
await cli.stepCommand('restart');
// For `restart`, sync on attach/prompt instead of BREAK_MESSAGE to avoid flaky races.
// https://github.com/nodejs/node/issues/61762
await cli.command('restart');
await cli.waitFor(/Debugger attached\./);
await cli.waitForPrompt();
assert.strictEqual(cli.output.match(listeningRegExp).length, 1);
}
} finally {
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-debugger-run-after-quit-restart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const path = require('path');
{ filename: script, line: 2 },
);
})
.then(() => cli.stepCommand('restart'))
.then(() => cli.command('restart'))
.then(() => cli.waitForInitialBreak())
.then(() => {
assert.deepStrictEqual(
Expand Down