Skip to content

build: generate_config_gypi.py generates valid JSON #61791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codebytere wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

build: generate_config_gypi.py generates valid JSON #61791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tools/generate_config_gypi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def translate_config(out_dir, config, v8_config):
'llvm_version': 13,
'napi_build_version': config['napi_build_version'],
'node_builtin_shareable_builtins':
eval(config['node_builtin_shareable_builtins']),
json.loads(config['node_builtin_shareable_builtins']),
'node_module_version': int(config['node_module_version']),
'node_use_openssl': config['node_use_openssl'],
'node_use_amaro': config['node_use_amaro'],
Expand Down Expand Up @@ -102,7 +102,8 @@ def main():

# Write output.
with open(args.target, 'w') as f:
f.write(repr(translate_config(args.out_dir, config, v8_config)))
f.write(json.dumps(translate_config(args.out_dir, config, v8_config),
sort_keys=True))

# Write depfile. Force regenerating config.gypi when GN configs change.
if args.dep_file:
Expand Down
Loading