docs: fix unclosed link in Test Runner documentation#62168
Closed
KJyang-0114 wants to merge 3 commits intonodejs:mainfrom
Closed
docs: fix unclosed link in Test Runner documentation#62168KJyang-0114 wants to merge 3 commits intonodejs:mainfrom
KJyang-0114 wants to merge 3 commits intonodejs:mainfrom
Conversation
When coverage threshold is not met, the dot reporter now outputs the error message so users can understand why tests failed. Refs: nodejs#60884
Add documentation explaining how to mock functions that throw errors and validate them using assert.throws(). Includes examples showing how mock tracks both successful calls and thrown errors. PR-URL: nodejs#52358 Refs: nodejs#52357
Fixes an unclosed link tag that causes all text after it to be underlined and clickable in the HTML documentation. Before: [<RegExp>] After: [RegExp]
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Contributor
|
Thanks for your contribution! However this PR contains unrelated changes, and the linked issue is already resolved by #62100 |
Member
|
Yes, this was already fixed. Thanks but closing as a duplicate. |
JakobJingleheimer
added
the
duplicate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is an unclosed link tag in the Test Runner documentation (). This causes all text after the link to be underlined and clickable in the rendered HTML.
The issue was reported in: #62154
Root Cause
Line 291-294 had incorrect markdown:
[<RegExp>]instead of[RegExp]. The extra<at the beginning of each link text breaks the link parsing.Fix
Removed the stray
<characters from the link text:[<RegExp>]→[RegExp][<Function>]→[Function][<Object>]→[Object][<Error>]→[Error]Testing
Checklist