test: use common spawnSync helpers in more tests - #65552
Open
greenheadHQ wants to merge 3 commits into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
avivkeller
approved these changes
Aug 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65552 +/- ##
==========================================
- Coverage 90.08% 90.07% -0.01%
==========================================
Files 751 751
Lines 254865 254875 +10
Branches 48114 48120 +6
==========================================
- Hits 229586 229582 -4
- Misses 16467 16496 +29
+ Partials 8812 8797 -15 🚀 New features to boost your workflow:
|
atlowChemi
approved these changes
Aug 26, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
aduh95
reviewed
Aug 26, 2026
aduh95
reviewed
Aug 26, 2026
aduh95
reviewed
Aug 26, 2026
aduh95
reviewed
Aug 26, 2026
lpinca
approved these changes
Aug 26, 2026
Collaborator
The helpers report the command, both streams, and the exit condition on failure, so mismatches are diagnosed consistently across tests. Signed-off-by: greenhead <greenheadhq@gmail.com>
Signed-off-by: greenhead <greenheadhq@gmail.com>
Signed-off-by: greenhead <greenheadhq@gmail.com>
greenheadHQ
force-pushed
the
use-spawnsync-helpers
branch
from
August 27, 2026 11:48
40307b2 to
d43187e
Compare
Contributor
Author
|
Rebased onto main. #64003 added a new |
aduh95
approved these changes
Aug 27, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces manual
spawnSync()result assertions with thetest/common/child_processhelpers in eight tests, following the same approach as #65377. Every existing expectation (status, signal, stream contents) is preserved, and the helpers report the command and both streams when a check fails.This also adds a signal check at call sites that previously only compared status, matching the helper defaults.
Only success-path blocks whose assertions map one-to-one onto the helper defaults are converted. blocks that assert bespoke failure modes are left unchanged.
Refs: #65377