worker: emit worker exit notifications on BroadcastChannel - #65575
worker: emit worker exit notifications on BroadcastChannel#65575SudhansuBandha wants to merge 1 commit into
Conversation
Expose worker termination notifications through BroadcastChannel so consumers can observe when a worker exits and inspect its thread ID and exit code. Fixes: nodejs#59053 Signed-off-by: SudhansuBandha <bandhasudhansu@gmail.com>
Labeeb2339
left a comment
There was a problem hiding this comment.
The current lint-cpp check reports 10 style errors in the new C++ code, so this PR is not yet lint-clean. Notably: trailing whitespace at src/node_messaging.cc:855 and src/node_messaging.h:194/233/235, an over-80-character line at src/node_messaging.cc:896, missing spaces in if(environment->is_stopping()) at :970, and incorrect indentation around WorkerExitNotification in src/node_messaging.h:226-229. Running the repository C++ formatter/linter and committing its output should address these before the functional review proceeds.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65575 +/- ##
=======================================
Coverage 90.05% 90.06%
=======================================
Files 751 751
Lines 254868 254937 +69
Branches 48107 48116 +9
=======================================
+ Hits 229531 229608 +77
+ Misses 16511 16495 -16
- Partials 8826 8834 +8
🚀 New features to boost your workflow:
|
Expose worker termination notifications through BroadcastChannel so consumers can observe when a worker exits and inspect its thread ID and exit code.
Fixes: #59053