process: expose enhanced stack trace to uncaughtException handlers - #65580
Open
santusht06 wants to merge 1 commit into
Open
process: expose enhanced stack trace to uncaughtException handlers#65580santusht06 wants to merge 1 commit into
santusht06 wants to merge 1 commit into
Conversation
When an EventEmitter instance emits an unhandled 'error' event, Node
attaches an internal stack enhancer (`kEnhanceStackBeforeInspector`)
capturing the call site of the `emit('error', ...)` invocation.
However, `createOnGlobalUncaughtException()` was dispatching the error
to `uncaughtExceptionMonitor` and `uncaughtException` listeners before
running `fatalExceptionStackEnhancers.beforeInspector(er)`.
As a result, custom uncaught exception handlers and monitoring
libraries did not receive the enhanced call site on `err.stack`.
This commit runs `fatalExceptionStackEnhancers.beforeInspector(er)`
before emitting `uncaughtExceptionMonitor` and `uncaughtException`,
ensuring the full emitter call site is accessible to handlers.
Fixes: nodejs#55838
Signed-off-by: Santusht kotai <115890693+santusht06@users.noreply.github.com>
nodejs-github-bot
added
needs-ci
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an
EventEmitterinstance emits an unhandled'error'event, Node attaches an internal stack enhancer (kEnhanceStackBeforeInspector) capturing the call site whereemit('error', ...)was invoked.However,
createOnGlobalUncaughtException()inlib/internal/process/execution.jswas dispatching the error touncaughtExceptionMonitoranduncaughtExceptionlisteners before executingfatalExceptionStackEnhancers.beforeInspector(er).As a result, custom uncaught exception handlers and APM monitoring libraries were unable to access the enhanced call site on
err.stack.Changes
fatalExceptionStackEnhancers.beforeInspector(er)increateOnGlobalUncaughtException()prior to emittinguncaughtExceptionMonitoranduncaughtException.test/parallel/test-process-uncaught-exception-enhanced-stack.jsto verify that bothuncaughtExceptionMonitoranduncaughtExceptionreceive the enhancederr.stackcontaining theemit('error', ...)call site forEventEmitterand subclass instances.Fixes: #55838