Skip to content

test: deflake test-inspect-async-hook-setup-at-inspect #65584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christianaurichzm wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

test: deflake test-inspect-async-hook-setup-at-inspect #65584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions test/parallel/test-inspect-async-hook-setup-at-inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@ async function waitForInitialSetup(session) {
await session.waitForBreakOnLine(2, '[eval]');
}

// Sent only once the target is paused. While the target runs JS the command
// is dispatched from a V8 interrupt, where Agent::SyncAsyncHookState() cannot
// call into JS and defers enabling the async hook to an immediate that the
// pause then blocks, answering the command anyway. Dispatching from the paused
// message loop enables the hook inline, so the response is a real barrier.
async function enableAsyncStackTraces(session) {
console.error('[test]', 'Enabling async stack traces');
await session.send({ 'method': 'Debugger.setAsyncCallStackDepth',
'params': { 'maxDepth': 10 } });
}

async function setupTimeoutForStackTrace(session) {
console.error('[test]', 'Setting up timeout for async stack trace');
await session.send([
Expand All @@ -50,13 +61,12 @@ async function runTests() {
await session.send([
{ 'method': 'Runtime.enable' },
{ 'method': 'Debugger.enable' },
{ 'method': 'Debugger.setAsyncCallStackDepth',
'params': { 'maxDepth': 10 } },
{ 'method': 'Debugger.setBlackboxPatterns',
'params': { 'patterns': [] } },
]);

await waitForInitialSetup(session);
await enableAsyncStackTraces(session);
await setupTimeoutForStackTrace(session);
await checkAsyncStackTrace(session);

Expand Down
Loading