sqlite: validate connection after reading options - #65591
Open
lazerg wants to merge 2 commits into
Open
Conversation
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
Collaborator
|
Review requested:
|
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65591 +/- ##
=======================================
Coverage 90.07% 90.08%
=======================================
Files 751 751
Lines 254875 254895 +20
Branches 48108 48137 +29
=======================================
+ Hits 229579 229617 +38
+ Misses 16466 16459 -7
+ Partials 8830 8819 -11
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
function(),aggregate(),deserialize(),prepare(),applyChangeset(),backup()and the tag store check that the connection is open before reading their options bag. A getter on that object can calldb.close(), leaving the rest of the call running against a null connection. Five of them segfault;prepare()and the tag store reportERR_SQLITE_ERROR: out of memoryinstead.The open check now runs again once the options have been read, right before the connection reaches SQLite. Re-checking keeps the current error precedence, which parsing the options up front the way
createSession()does would change.Fixes: #65586