Skip to content

[v26.x] Backport doc-only deprecations - #65593

Open
aduh95 wants to merge 1 commit into
nodejs:v26.x-stagingfrom
aduh95:backport-deprecations
Open

[v26.x] Backport doc-only deprecations#65593
aduh95 wants to merge 1 commit into
nodejs:v26.x-stagingfrom
aduh95:backport-deprecations

Conversation

@aduh95

@aduh95 aduh95 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Annoyingly those landed on main as semver-major, but we still want to backport the doc-only deprecation otherwise it conflicts with future doc-only deprecations.

Refs: #63249
Refs: #64794

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch. labels Aug 27, 2026
@aduh95 aduh95 added the notable-change PRs with changes that should be highlighted in changelogs. label Aug 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @aduh95.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@pimterry

Copy link
Copy Markdown
Member

Arghhh, I'm not sure what best practice is here, but the HTTP/2 deprecation doesn't make much sense without the semver major change it was attached to. The recommendation here is wrong in older versions (i.e. all released versions today) and the example code won't work as described. To resolve the deprecation, you need the new breaking functionality. This is hard to avoid unfortunately...

Do we include it anyway, but say "From Node v27..."? Or reserve the deprecation number to fix the immediate conflict, and update the actual content in v27? Sorry, my fault, I should've considered this in more detail with the original breaking change.

@aduh95

aduh95 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Is there any way for users of Node.js 26 to prepare for that deprecation? If not, let's indeed not backport it, there's a way to skip deprecation numbers thankfully:

node/doc/api/deprecations.md

Lines 2150 to 2152 in d6e67a5

<!-- md-lint skip-deprecation DEP0087 -->
<!-- md-lint skip-deprecation DEP0088 -->

@pimterry

Copy link
Copy Markdown
Member

Is there any way for users of Node.js 26 to prepare for that deprecation?

Not really, no, I think skipping the deprecation number for now is the best fix.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
aduh95 force-pushed the backport-deprecations branch from c8b79c4 to 129a5b1 Compare August 27, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants