[v26.x] Backport doc-only deprecations - #65593
Conversation
|
Review requested:
|
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
|
Arghhh, I'm not sure what best practice is here, but the HTTP/2 deprecation doesn't make much sense without the semver major change it was attached to. The recommendation here is wrong in older versions (i.e. all released versions today) and the example code won't work as described. To resolve the deprecation, you need the new breaking functionality. This is hard to avoid unfortunately... Do we include it anyway, but say "From Node v27..."? Or reserve the deprecation number to fix the immediate conflict, and update the actual content in v27? Sorry, my fault, I should've considered this in more detail with the original breaking change. |
|
Is there any way for users of Node.js 26 to prepare for that deprecation? If not, let's indeed not backport it, there's a way to skip deprecation numbers thankfully: Lines 2150 to 2152 in d6e67a5 |
Not really, no, I think skipping the deprecation number for now is the best fix. |
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
c8b79c4 to
129a5b1
Compare
Annoyingly those landed on
mainas semver-major, but we still want to backport the doc-only deprecation otherwise it conflicts with future doc-only deprecations.Refs: #63249
Refs: #64794