Repository navigation
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Additional integration validation: full RISC-V cross-build passed with Temporal enabled, including staged installation and QEMU runtime smoke tests. This run combined #66804, #66823, and candidate V8 fixes. The full Node.js test suite was not run. |
Capture the Rust target and host triples during configure for bundled Temporal cross builds. Use explicit Cargo targets and separate output directories so host and target archives do not share a build rule. Refs: nodejs#66803 Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
inoway46
force-pushed
the
build-rust-cross-targets
branch
from
October 21, 2026 12:01
19c9345 to
5ff420e
Compare
inoway46
marked this pull request as ready for review
October 21, 2026 12:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate host and target Rust archives in bundled Temporal cross builds by capturing the Rust target triples during configure and using distinct Cargo output directories.
Validated archive generation and Temporal FFI linking/execution with Make for Linux x86_64 cross builds targeting AArch64 and RISC-V.
Fixes: #66897
Refs: #66803