Skip to content

feat(ui): improve partner grid layout on download page #8750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shubham-1068 wants to merge 5 commits into
base: main
Choose a base branch
from
+11 −8
Open

feat(ui): improve partner grid layout on download page #8750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa63c7f
feat(ui): improve partner grid layout on download page
Shubham-1068 Mar 21, 2026
f32d88a
Merge branch 'nodejs:main' into download-partners-ui-improvement
Shubham-1068 Mar 21, 2026
adddbc1
feat(ui): adjust large partner grid layout for better responsiveness
Shubham-1068 Mar 21, 2026
6c4d2be
fix: update import statements to use createQueries for consistency
Shubham-1068 Mar 21, 2026
d29fcc8
Merge branch 'nodejs:main' into download-partners-ui-improvement
Shubham-1068 Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/site/components/Common/Partners/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
.large {
@apply grid
w-full
grid-cols-[repeat(auto-fill,minmax(240px,1fr))]
gap-4;
gap-6
lg:grid-cols-[repeat(auto-fit,minmax(240px,260px))]
lg:justify-center;
}
4 changes: 2 additions & 2 deletions packages/remark-lint/src/rules/duplicate-stability-nodes.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { QUERIES } from '@node-core/doc-kit/src/utils/queries/index.mjs';
import createQueries from '@node-core/doc-kit/src/utils/queries/index.mjs';
Copy link
Member

@ovflowd ovflowd Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? Seems wrong. I recall we switched from createQueries to { QUERIES }? cc @avivkeller

Copy link
Member

@bjohansebas bjohansebas Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are not related to the objective of this PR.

import { lintRule } from 'unified-lint-rule';
import { visit } from 'unist-util-visit';

Expand Down Expand Up @@ -29,7 +29,7 @@ const duplicateStabilityNodes = (tree, vfile) => {
return;
}

const match = QUERIES.stabilityIndexPrefix.exec(text); // Match "Stability: X"
const match = createQueries.QUERIES.stabilityIndexPrefix.exec(text);
if (!match) {
return;
}
Expand Down
10 changes: 6 additions & 4 deletions packages/remark-lint/src/rules/invalid-type-reference.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { transformTypeToReferenceLink } from '@node-core/doc-kit/src/generators/metadata/utils/transformers.mjs';
import { QUERIES } from '@node-core/doc-kit/src/utils/queries/index.mjs';
import { transformTypeToReferenceLink } from '@node-core/doc-kit/src/utils/parser/index.mjs';
import createQueries from '@node-core/doc-kit/src/utils/queries/index.mjs';
import { lintRule } from 'unified-lint-rule';
import { visit } from 'unist-util-visit';

Expand All @@ -13,9 +13,10 @@ const REPLACE_RE = /\s*\| */g;
const invalidTypeReference = (tree, vfile, { typeMap = {} }) => {
visit(
tree,
({ value }) => QUERIES.normalizeTypes.test(value),
({ value }) => createQueries.QUERIES.normalizeTypes.test(value),
node => {
const types = node.value.match(QUERIES.normalizeTypes);
const types =
node.value.match(createQueries.QUERIES.normalizeTypes) ?? [];

types.forEach(type => {
// Ensure wrapped in {}
Expand All @@ -39,6 +40,7 @@ const invalidTypeReference = (tree, vfile, { typeMap = {} }) => {

const normalized = type.replace(REPLACE_RE, '|');
node.value = node.value.replace(type, normalized);
type = normalized;
}

if (transformTypeToReferenceLink(type, typeMap) === type) {
Expand Down