Skip to content

Test MathML rendering#8756

Closed
joyeecheung wants to merge 2 commits intonodejs:mainfrom
joyeecheung:mathml-rendering
Closed

Test MathML rendering#8756
joyeecheung wants to merge 2 commits intonodejs:mainfrom
joyeecheung:mathml-rendering

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Mar 22, 2026

See https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1773767767803919

Just testing MathML rendering on the website in the preview. Not to be published.

@joyeecheung joyeecheung requested a review from a team as a code owner March 22, 2026 14:53
Copilot AI review requested due to automatic review settings March 22, 2026 14:53
@vercel
Copy link

vercel bot commented Mar 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Mar 22, 2026 3:28pm

Request Review

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@codecov
Copy link

codecov bot commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.24%. Comparing base (7ec1349) to head (40a7da6).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8756      +/-   ##
==========================================
- Coverage   75.27%   75.24%   -0.04%     
==========================================
  Files         105      105              
  Lines        9242     9242              
  Branches      326      327       +1     
==========================================
- Hits         6957     6954       -3     
- Misses       2283     2286       +3     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new blog post intended to serve as a manual fixture for verifying MathML rendering on the site.

Changes:

  • Adds a new uncategorized blog post page containing block and inline MathML examples (series sums, RMSE/NRMSE, bitwise identities).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@joyeecheung
Copy link
Member Author

joyeecheung commented Mar 22, 2026

This does not look correct. It looks like this in the preview https://nodejs-org-git-fork-joyeecheung-mathml-rendering-openjs.vercel.app/en/blog/uncategorized/mathml-rendering

Screenshot 2026-03-22 at 15 55 28

For reference pasting the same thing in HackMD gives me

Screenshot 2026-03-22 at 16 03 56

@avivkeller avivkeller self-assigned this Mar 22, 2026
@joyeecheung joyeecheung marked this pull request as draft March 22, 2026 15:23
@joyeecheung
Copy link
Member Author

Looks like switching to .mdx would make it just work. See https://nodejs-cx5bhldw5-openjs.vercel.app/en/blog/uncategorized/mathml-rendering

Closing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants