fix(site): apply absolute positioning and full dimensions to HexagonGrid in OG images#8909
fix(site): apply absolute positioning and full dimensions to HexagonGrid in OG images#8909ubay1 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 6754a67. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
this is indeed better, despite my comment in the issue
thanks!!!!
prod https://nodejs.org/en/next-data/og/announcement/Node.js%20%E2%80%94%20Run%20JavaScript%20Everywhere
fixed https://nodejs-acgakz6es-openjs.vercel.app/en/next-data/og/announcement/Node.js%20%E2%80%94%20Run%20JavaScript%20Everywhere
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8909 +/- ##
==========================================
- Coverage 73.24% 73.19% -0.06%
==========================================
Files 102 102
Lines 8628 8628
Branches 313 314 +1
==========================================
- Hits 6320 6315 -5
- Misses 2307 2312 +5
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Description
This PR fixes the OG image layout issue by applying absolute positioning and full dimensions to
HexagonGrid.Validation
pnpm formatpnpm testpnpm buildRelated Issues
#8886 Fixes OG image rendering issue.