Skip to content

fix(site): apply absolute positioning and full dimensions to HexagonGrid in OG images#8909

Open
ubay1 wants to merge 1 commit into
nodejs:mainfrom
ubay1:fix/og-image
Open

fix(site): apply absolute positioning and full dimensions to HexagonGrid in OG images#8909
ubay1 wants to merge 1 commit into
nodejs:mainfrom
ubay1:fix/og-image

Conversation

@ubay1
Copy link
Copy Markdown

@ubay1 ubay1 commented May 20, 2026

Description

This PR fixes the OG image layout issue by applying absolute positioning and full dimensions to HexagonGrid.

Validation

  • Ran pnpm format
  • Ran pnpm test
  • Ran pnpm build

Related Issues

#8886 Fixes OG image rendering issue.

@ubay1 ubay1 requested a review from a team as a code owner May 20, 2026 13:49
@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview May 20, 2026 1:50pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 20, 2026

PR Summary

Low Risk
Low risk UI/layout-only change limited to OG image rendering; main risk is minor visual regressions in generated images.

Overview
Fixes OG image layout by forcing the HexagonGrid background to be absolute positioned and fill the full 1200x600 canvas, ensuring the radial gradient grid consistently covers the entire OpenGraph image behind the centered title/logo.

Reviewed by Cursor Bugbot for commit 6754a67. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.19%. Comparing base (5453a6f) to head (6754a67).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8909      +/-   ##
==========================================
- Coverage   73.24%   73.19%   -0.06%     
==========================================
  Files         102      102              
  Lines        8628     8628              
  Branches      313      314       +1     
==========================================
- Hits         6320     6315       -5     
- Misses       2307     2312       +5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants