Closed
Conversation
When a MockAgent had a delayed response and the request was aborted via AbortSignal, the delayed response callback would still fire and attempt to call handler methods after onError had been called. This violated state invariants expected by handlers like DecoratorHandler (used by decompress interceptor). The fix: - Tracks abort state in mockDispatch - Clears pending setTimeout timer when abort is called - Checks abort flag in handleReply before invoking handler callbacks - Properly calls handler.onConnect to register abort callback Fixes #4693
In cases where onParserTimeout is called with a weak reference that has
already been collected it was throwing an error like:
Cannot destructure property 'socket' of 'parser.deref(...)' as it is
undefined
- Fixes #4755
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 6.0.0 to 6.2.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@2028fbc...6044e13) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 6.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: error stream instead of canceling Co-authored-by: Matteo Collina <hello@matteocollina.com> * fixup --------- Co-authored-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Updated code block syntax highlighting from 'mjs' to 'js' so that syntax highlighting works.
Bumps [esbuild](https://github.com/evanw/esbuild) from 0.25.12 to 0.27.3. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md) - [Commits](evanw/esbuild@v0.25.12...v0.27.3) --- updated-dependencies: - dependency-name: esbuild dependency-version: 0.27.3 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
0412b78 to
09862a2
Compare
ronag
previously approved these changes
Feb 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4823 +/- ##
==========================================
- Coverage 93.17% 93.16% -0.02%
==========================================
Files 109 109
Lines 34187 34187
==========================================
- Hits 31855 31849 -6
- Misses 2332 2338 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
ahum, didn't work as expected. |
Member
Author
|
I think it needs a rebase, let me give it a shot |
Member
Author
|
Closed in favor of #4828 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
This enables HTTP/2 support by default in Undici.
Rationale
Currently, users must explicitly opt-in to H2 support via
allowH2: true. This change adjusts Undici's defaults to align with current web standards and improve out-of-the-box performance.Changes
This PR changes the default value of the
allowH2option fromfalsetotruein the connection builder (lib/core/connect.js). When connecting to HTTPS servers, Undici will now use HTTP/2 if the server advertises it through ALPN negotiation, falling back to HTTP/1.1 if not supported.Features
allowH2: falsein client optionsBug Fixes
N/A
Breaking Changes and Deprecations
Breaking Change: The default value of
allowH2changes fromfalsetotrue.Impact:
allowH2: falsein their client configurationStatus