Feat(`node url to whatwg url`) by AugustinMauroy · Pull Request #172 · nodejs/userland-migrations

AugustinMauroy · 2025-08-12T11:55:59Z

Description

Add codemod for node:url legacy object to whatWG url

Related issue

close #92

This reverts commit c5ce549.

recipes/node-url-to-whatwg-url/README.md

recipes/node-url-to-whatwg-url/codemod.yaml

recipes/node-url-to-whatwg-url/workflow.yaml

recipes/node-url-to-whatwg-url/package.json

recipes/node-url-to-whatwg-url/src/url-parse.ts

styfle · 2025-09-04T13:15:45Z

recipes/node-url-to-whatwg-url/tests/url-parse/input/file-1.js

@@ -0,0 +1,18 @@
+const url = require('node:url');
+
+const myURL = url.parse('https://example.com/path?query=string#hash');


Please add a test for parsing a relative url, for example:

url.parse('/path?query=string#hash')

JakobJingleheimer

Generally looks good! A couple things though:

Dynamic imports?
I think the var → let needs to get removed because it can easily break user code. (Requesting changes on this)

Also, I think Steven's request is a good one.

nit: I think indentation might be inconsistent across files? (spaces vs tabs)

PS Sorry it took me a bit to get to this 😓

biome.jsonc

recipes/node-url-to-whatwg-url/src/import-process.ts

recipes/node-url-to-whatwg-url/src/url-format.ts

recipes/node-url-to-whatwg-url/src/url-parse.ts

AugustinMauroy · 2025-09-27T21:20:34Z

update:

add test
I didn't replace return undefined by return; because I prefer to be explicit
String.raw isn't really useful because it's only escape \ and not `

JakobJingleheimer · 2025-10-16T09:45:20Z

@AugustinMauroy is there a deprecation for this?

brunocroh · 2025-10-16T10:31:36Z

@AugustinMauroy is there a deprecation for this?

This one is for https://nodejs.org/api/deprecations.html#DEP0116, I know because it’s described in the README.

But I think it can handle https://nodejs.org/api/deprecations.html#DEP0169 as well

recipes/node-url-to-whatwg-url/README.md

recipes/node-url-to-whatwg-url/src/url-parse.ts

styfle · 2025-10-21T15:47:48Z

recipes/node-url-to-whatwg-url/README.md

 const myUrl = new URL('https://example.com/some/path?page=1&format=json').toString();
 ```

+> **Note:** The migration of `url.format` can also be done as `` `${new URL('https://example.com/some/path?page=1&format=json')}` `` which is little bit efficienter.


efficienter => more efficient

I thought i already caught that 🤔

styfle · 2025-10-21T15:49:10Z

recipes/node-url-to-whatwg-url/tests/url-parse/expected/file-10.js

@@ -0,0 +1,13 @@
+const url = require('node:url');
+
+const myURL = new URL('/path?query=string#hash');


This throws an error

Uncaught TypeError: Failed to construct 'URL': Invalid URL

@AugustinMauroy This codemod is very dangerous because it will cause apps to crash at runtime.

@styfle if you can provide a better before/after example that can be used as test that will help us to fix this issue

How so?

@JakobJingleheimer I'm not sure how else to explain. If you run the code it will throw:

if you can provide a better before/after example

@AugustinMauroy The before is fine. The after is wrong. It should not transform the code at all. It needs to preserve the original url.parse('/path?query=string#hash')

I created an issue to track this bug: #249

JakobJingleheimer · 2026-02-02T22:48:26Z

@AugustinMauroy FYI: there were some undocumented pieces to a recent related deprecation (DEP0169) that may affect this: nodejs/node#61644

AugustinMauroy added 11 commits August 12, 2025 11:51

fea(node-url-to-whatwg-url): scaffold codemod

cdcdffe

url-parse(node-url-to-whatwg-url): setup url-parse

3addfb3

WIP

04174b8

url-parse(node-url-to-whatwg-url): introduce

4249d8e

clean

873775a

WIP

4cf1c36

fix: ts

ab18017

fix: windows

4b60d03

use resolve utility

b289b2d

add more supported case for url-format

50193e0

test: add more case

264a1f2

AugustinMauroy marked this pull request as ready for review August 12, 2025 18:58

AugustinMauroy requested a review from a team August 12, 2025 18:58

AugustinMauroy added 3 commits August 12, 2025 21:38

add support of semicolon

c60c073

Update package.json

c5ce549

Revert "Update package.json"

cedf9bc

This reverts commit c5ce549.

brunocroh reviewed Aug 12, 2025

View reviewed changes

AugustinMauroy added 13 commits August 13, 2025 00:23

update

0adc023

fea(node-url-to-whatwg-url): scaffold codemod

599fff4

url-parse(node-url-to-whatwg-url): setup url-parse

a4ff1db

WIP

4aeffdd

url-parse(node-url-to-whatwg-url): introduce

0b1f00a

clean

729f5f8

WIP

0914a53

fix: ts

d8debdf

fix: windows

b431aa4

use resolve utility

25f7df2

add more supported case for url-format

36f3b79

test: add more case

821e3ee

add support of semicolon

0713b1e

anonrig approved these changes Sep 2, 2025

View reviewed changes

styfle reviewed Sep 4, 2025

View reviewed changes

JakobJingleheimer requested changes Sep 16, 2025

View reviewed changes

AugustinMauroy added 2 commits September 27, 2025 22:36

Merge branch 'main' into feat(node-url-to-whatwg-url)

1570a39

applied feedback

2529223

AugustinMauroy added the awaiting reviewer Author has responded and needs action from the reviewer label Sep 27, 2025

JakobJingleheimer added dep:v24 Migration handles deprecation introduced in node v24 dep:EoL Migration handles deprecation introduced in an EoL version of node labels Oct 16, 2025

JakobJingleheimer approved these changes Oct 17, 2025

View reviewed changes

recipes/node-url-to-whatwg-url/README.md Outdated Show resolved Hide resolved

recipes/node-url-to-whatwg-url/src/url-parse.ts Outdated Show resolved Hide resolved

JakobJingleheimer added awaiting author Reviewer has requested something from the author and removed awaiting reviewer Author has responded and needs action from the reviewer labels Oct 18, 2025

AugustinMauroy added 2 commits October 18, 2025 18:38

Merge branch 'main' into feat(node-url-to-whatwg-url)

8a57d09

update

c13769e

AugustinMauroy added awaiting reviewer Author has responded and needs action from the reviewer and removed awaiting author Reviewer has requested something from the author labels Oct 18, 2025

JakobJingleheimer approved these changes Oct 18, 2025

View reviewed changes

JakobJingleheimer added awaiting author Reviewer has requested something from the author and removed awaiting reviewer Author has responded and needs action from the reviewer labels Oct 18, 2025

Merge branch 'main' into feat(node-url-to-whatwg-url)

ae6a29a

brunocroh approved these changes Oct 18, 2025

View reviewed changes

AugustinMauroy merged commit fc8c3d2 into main Oct 18, 2025
36 checks passed

JakobJingleheimer removed the awaiting author Reviewer has requested something from the author label Oct 18, 2025

styfle reviewed Oct 21, 2025

View reviewed changes

styfle mentioned this pull request Oct 21, 2025

Brainstorm: url.parse() -> new url #92

Closed

JakobJingleheimer deleted the feat(`node-url-to-whatwg-url`) branch December 13, 2025 11:51

		@@ -0,0 +1,18 @@
		const url = require('node:url');

		const myURL = url.parse('https://example.com/path?query=string#hash');

		@@ -0,0 +1,13 @@
		const url = require('node:url');

		const myURL = new URL('/path?query=string#hash');

Uh oh!

Conversation

AugustinMauroy commented Aug 12, 2025

Description

Related issue

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AugustinMauroy commented Sep 27, 2025

Uh oh!

JakobJingleheimer commented Oct 16, 2025

Uh oh!

brunocroh commented Oct 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

styfle Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer commented Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

styfle Oct 27, 2025 •

edited

Loading