Add app icon and richer demo for MarkdownEngineDemo#30
Merged
Conversation
Adds MarkdownEngineCodeBlocks and MarkdownEngineLatex as opt-in product dependencies on the demo target, plugs the bundled bridges in via #if canImport, and rebuilds the sample markdown as a dynamic composition so each feature section either showcases the bridge or links to the README section that explains how to enable it.
Collaborator
Author
|
@luca-chen198 can you pls review the conditional md demo. It should now autoswitch based on configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MDE.icon) to the demo target so it shows up in the Dock and app switcher when the demo runs.MarkdownEngineCodeBlocksandMarkdownEngineLatexinto the demo target and plugs the bundledHighlighterSwiftBridge/SwiftMathBridgein via#if canImport(...), so the demo finally shows what the engine can render end-to-end.sampleMarkdownwith a dynamic composition. Each feature section (inline formatting, block math, code) either showcases its bridge or, if the matching product isn't linked, falls back to a short note linking to the README section that explains how to enable it.Closes
Closes #20.
Test plan
Demo/MarkdownEngineDemo.xcodeprojin Xcode 26+ and Run. Confirm the new icon appears in the Dock and in the app switcher.MarkdownEngineLatexfrom the demo target's Package Dependencies and rebuild — the demo should still compile, the inline-math sentence should be gone, and a## LaTeXsection should appear linking to the README. Re-add it before merging.MarkdownEngineCodeBlocks— the## Codesection should fall back to a plain-monospacelet greeting = "Hello, world!"block with a README link. Re-add it before merging.