Merge xVanTuring's GFM features + local bug fixes#37
Open
luca-chen198 wants to merge 6 commits into
Open
Conversation
This reverts commit 1988aac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-introduces @xVanTuring's CommonMark/GFM feature contributions from his fork (https://github.com/xVanTuring/swift-markdown-engine/tree/main) together with local follow-up bug fixes.
The original merge was performed and pushed prematurely (commit
2ad2dee), then reverted (1988aac) so we could land it through a proper review workflow. This PR re-applies the same changes via a "revert the revert" commit. xVanTuring's original per-commit attribution is preserved in the git history (reachable through2ad2dee).From xVanTuring's branch (22 commits)
~~strikethrough~~,_italic_/__bold__, N-backtick code spans, CommonMark backslash escapes,markdown image links-/*/+, space-indented nested bullets, backspace-restore on empty-Local follow-ups (commit
76bad45)NSRangeExceptionbounds-guard against TextKit's synthetic trailing line fragment (crash on Enter)$...$inside a table — the stray.latexImagetag was drawing a tiny image as a dot on the collapsed source lineremoveLinePrefixAndExithelper, shared by list-exit and quote-exitTest plan
>,>>,>>>), Enter continuation, Enter on empty exits without crash---,***,___); Enter on HR line doesn't crash; click on HR reveals raw source)[ ]/[x]) still togglemain— no visual regressions in non-GFM cases