auxiliary: use shutil instead of distutils for recursiveCopy#125
Open
tpwrules wants to merge 1 commit into
Open
auxiliary: use shutil instead of distutils for recursiveCopy#125tpwrules wants to merge 1 commit into
tpwrules wants to merge 1 commit into
Conversation
distutils does not exist in Pythons >= 3.12, so the program does not work since the import fails. Instead, when possible, use shutil to provide a tree copy function. The relevant difference between the two implementations is that distutils' version does not raise an error if the destination directory exists. Unfortunately, the flag to match this behavior, only exists in shutil's implementation on Pythons >= 3.8. Therefore, we fall back on distutils to preserve compatibility with these EOL versions. Tested that elf_diff now starts and works on Python 3.12 using the `html_dir` exporter.
tpwrules
force-pushed
the
pr/fix-recursive-copy
branch
from
aa44c27 to
0d31674
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
distutils does not exist in Pythons >= 3.12, so the program does not work since the import fails. Instead, when possible, use shutil to provide a tree copy function.
The relevant difference between the two implementations is that distutils' version does not raise an error if the destination directory exists. Unfortunately, the flag to match this behavior, only exists in shutil's implementation on Pythons >= 3.8. Therefore, we fall back on distutils to preserve compatibility with these EOL versions.
Tested that elf_diff now starts and works on Python 3.12 using the
html_direxporter.