Check for union account on rigboard#648
Open
jamesatjaminit wants to merge 3 commits intonottinghamtec:masterfrom
Open
Check for union account on rigboard#648jamesatjaminit wants to merge 3 commits intonottinghamtec:masterfrom
jamesatjaminit wants to merge 3 commits intonottinghamtec:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional if statement on the rigboard to check if the organisation has a union account and show "Authorisation" or "PO" language respectively. At the moment "PO Recieved" is only shown when a PO is inputted, it should also been shown if authorisation is not possible (No SU account).
Now when an org doesn't have an SU account and a PO hasn't been inputted, instead of showing "Authorisation ❌️" it shows "PO ❌️" for consistency. Authorisation is still shown as normal for all SU groups.
The diff is horrendous on GitHub, vscode does a better job of showing what's actually changed: