Wrap RealWorld state passing #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you! I have some ideas for improving the readability even more, but I'll merge this first. |
Owner
|
@LukaHorvat I've worked out my ideas here: 3a6928f. |
Contributor
Author
|
Nice! Is there really a benefit to having the unlifted data version if you always have to convert to and from the lifted variant? |
Owner
|
Yes. GHC can optimize the lifted variant away, as long as you immediately pattern match on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of manually passing the state token around this introduces a couple of functions to wrap it up in IO. In my testing the performance is the same.
Whether you find this easier to work with or not is, of course, up to you. Feel free to close the PR if you don't think this is an improvement.
Note: I'm using
unsafeDupablePerformIOeverywhere and the performance is the same as before but if I instead usedunsafePerformIOon theappDiffOpfunction (like it seems the original code does) then the performance on the quickcheck example drops somewhat.