[codex] Fix toolbar column test notification context#1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TableToolBarColumnButtonstest renders inNotificationContextProvider.TableToolBaron its realuseNotifypath instead of mocking or weakening production behavior.Root Cause
TableToolBarnow reads notification context throughuseNotify, but this test harness only provided router and page contexts. Rendering the component in Jest therefore hit a null notification context.Validation
npx jest src/tests/components/TableToolBarColumnButtons.test.tsx --runInBandnpm run lint:frontendnpm run tsc:frontendnpm run lintandnpm run tscFixes #1164