fix: wire AbortSignal to osascript subprocess for clean cancellation#80
Open
ErnestHysa wants to merge 1 commit into
Open
fix: wire AbortSignal to osascript subprocess for clean cancellation#80ErnestHysa wants to merge 1 commit into
ErnestHysa wants to merge 1 commit into
Conversation
TheophilusChinomona
added a commit
to TheophilusChinomona/NotFair
that referenced
this pull request
Jun 29, 2026
…er picker, --no-open precedence Apply fixes from open upstream PRs that apply cleanly to our fork: - AbortSignal (nowork-studio#80, ErnestHysa): wire signal? parameter through pickFolder and pickFolderMac to execFile, enabling clean cancellation of osascript. Also extend to the new Linux execDialog helper. - Linux folder picker (nowork-studio#77, RohithVangalla1): implement pickFolderLinux using zenity (GTK) with kdialog (KDE) fallback, replacing the TODO stub. Linux users can now use the Browse button in the NotFair UI. - --no-open precedence (nowork-studio#92, Osamaali313): extract the auto-open guard in bin/notfair-content-calendar into a _should_auto_open helper that checks --no-open before platform. Fixes macOS/Windows ignoring the flag. Co-authored-by: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the AbortSignal not wired bug in pick-folder.ts. The osascript subprocess previously only had a 5-min hard timeout with no way to cancel it via AbortSignal. This change adds
signal?: AbortSignalsupport topickFolderand wires it toexecFilefor clean cancellation.