Fix --no-open ignored on macOS and Windows in content-calendar viewer

[Osamaali313]

Summary

The content-calendar viewer's --no-open flag ("Don't auto-open the browser") is ignored on macOS and Windows.

The auto-open guard in bin/notfair-content-calendar combines and/or without parentheses:

if not args.no_open and os.environ.get("DISPLAY", "") or sys.platform == "darwin" or sys.platform == "win32":

Since and binds tighter than or, this parses as:

(not args.no_open and DISPLAY) or (platform == "darwin") or (platform == "win32")

The two platform terms stand alone and never consult args.no_open. So on macOS and Windows — the two platforms where auto-open actually fires — the browser opens even when the user passes --no-open. (Headless Linux honored the flag, which is why it slipped through.)

Demonstration with --no-open set (correct result is False everywhere):

platform	before	after
darwin	True ❌	False
win32	True ❌	False
linux	False	False

Fix

Extract the decision into a small, testable helper that short-circuits on no_open first:

def _should_auto_open(no_open: bool, platform: str, display: str) -> bool:
    """Whether to auto-open the browser. Honors --no-open on every platform."""
    if no_open:
        return False
    return bool(display) or platform == "darwin" or platform == "win32"

if _should_auto_open(args.no_open, sys.platform, os.environ.get("DISPLAY", "")):

Default-open behavior is preserved exactly: GUI platforms (macOS/Windows, or Linux with $DISPLAY) still auto-open when --no-open is not passed; headless Linux still does not.

Testing

Added test/unit/test_content_calendar_auto_open.py (loads the bin script via importlib, matching test_broken_link_checker.py):

pytest test/unit/test_content_calendar_auto_open.py
3 passed

• --no-open suppresses auto-open on darwin / win32 / linux (this is what regressed).
• Default opens on macOS, Windows, and Linux-with-$DISPLAY; headless Linux does not.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.