ci: add homebrew action and docs#735
Conversation
|
@npalm please review |
npalm
left a comment
npalm
left a comment
There was a problem hiding this comment.
Thx, loooks good, but I think the action needs some adjustments. Did you tried running the action on a fork? In that case can you link the worfklow run?
| runs-on: ubuntu-latest | ||
| needs: release | ||
| steps: | ||
| - uses: mislav/bump-homebrew-formula-action@b3327118b2153c82da63fd9cbf58942146ee99f0 # v3 |
There was a problem hiding this comment.
Did you test the action on a branch with the release? Looking at the docs, I think we should set tag-name with the output of the release.
| formula-name: action-docs | ||
| formula-path: Formula/a/action-docs.rb | ||
| env: | ||
| COMMITTER_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
I think this won't work, it seems a PAT token is required here bacause as far I understand the token is used to open the PR or commit code to a PR. The GitHub token can't do that. It can only act in repo scop.
|
@nitrocode thanks, will merge the PR in an own branch to setup secrets and get it working. |
|
@nitrocode tried the action, but did not got it working. See https://github.com/npalm/action-docs/actions/runs/11764234621/job/32769405768 I get an unexpected 401. The token has repo and workflow acces. Any clue what the problem could be? |
* ci: add homebrew step * docs: add brew install * fix: address feedback
|
Moved the work to this PR, got it working |
2 participants
what
why
references