Conversation
roji
force-pushed
the
Sync
branch
2 times, most recently
from
edd9056 to
29ff46c
Compare
There was a problem hiding this comment.
Pull request overview
Updates the EFCore.PG provider/test suite to align with EF Core 11.0.0-preview.1, including framework/tooling changes and refreshed SQL baselines across many functional tests.
Changes:
- Bump target framework to
net11.0and update centralized EF Core / Microsoft.Extensions package versions to11.0.0-preview.1.*. - Update NuGet feeds and SDK pinning-related files.
- Refresh/expand many functional test overrides and SQL baselines to match EF11 query/update SQL generation.
Reviewed changes
Copilot reviewed 103 out of 103 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/EFCore.PG.FunctionalTests/UpdatesNpgsqlTest.cs | Updates expected identifier generation baseline. |
| test/EFCore.PG.FunctionalTests/Types/Temporal/NpgsqlTimeSpanTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Temporal/NpgsqlTimeOnlyTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Temporal/NpgsqlDateTimeUtcTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Temporal/NpgsqlDateTimeUnspecifiedTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Temporal/NpgsqlDateTimeOffsetTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Temporal/NpgsqlDateOnlyTypeTest.cs | Adds constant/parameter equality + SaveChanges baselines for DateOnly (but class naming needs correction). |
| test/EFCore.PG.FunctionalTests/Types/Numeric/NpgsqlShortTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Numeric/NpgsqlLongTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Numeric/NpgsqlIntTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Numeric/NpgsqlFloatTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Numeric/NpgsqlDoubleTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Numeric/NpgsqlDecimalTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Networking/NpgsqlMacaddrTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Networking/NpgsqlInetTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Miscellaneous/NpgsqlStringTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Miscellaneous/NpgsqlGuidTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Miscellaneous/NpgsqlByteArrayTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/Types/Miscellaneous/NpgsqlBoolTypeTest.cs | Splits equality tests into constant/parameter variants; adds SaveChanges SQL baseline. |
| test/EFCore.PG.FunctionalTests/TestUtilities/NpgsqlTestStore.cs | Updates store cleanup signature to accept createTables flag. |
| test/EFCore.PG.FunctionalTests/TestUtilities/NpgsqlDatabaseFacadeExtensions.cs | Adds createTables optional parameter to EnsureClean. |
| test/EFCore.PG.FunctionalTests/TestUtilities/NpgsqlDatabaseCleaner.cs | Updates cleaner to accept createTables; adds view handling + refactors custom SQL building. |
| test/EFCore.PG.FunctionalTests/RuntimeMigrationNpgsqlTest.cs | Adds provider-specific runtime migration test implementation. |
| test/EFCore.PG.FunctionalTests/Query/TPTInheritanceQueryNpgsqlTest.cs | Removes old minimal stub (moved/restructured under Inheritance namespace). |
| test/EFCore.PG.FunctionalTests/Query/TPTFiltersInheritanceQueryNpgsqlTest.cs | Removes old test type (replaced under Inheritance namespace). |
| test/EFCore.PG.FunctionalTests/Query/TPTFiltersInheritanceQueryNpgsqlFixture.cs | Removes old fixture type (replaced under Inheritance namespace). |
| test/EFCore.PG.FunctionalTests/Query/TPHInheritanceQueryNpgsqlTest.cs | Removes old minimal stub (moved/restructured under Inheritance namespace). |
| test/EFCore.PG.FunctionalTests/Query/TPCInheritanceQueryNpgsqlTest.cs | Removes old minimal stub (moved/restructured under Inheritance namespace). |
| test/EFCore.PG.FunctionalTests/Query/PrimitiveCollectionsQueryNpgsqlTest.cs | Adds/updates overrides and baselines for empty/huge collections and Contains variants; parameter name changes. |
| test/EFCore.PG.FunctionalTests/Query/NorthwindGroupByQueryNpgsqlTest.cs | Updates parameter naming/order in SQL baselines. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPTRelationshipsQueryNpgsqlTest.cs | Moves to Microsoft.EntityFrameworkCore.Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPTManyToManyQueryNpgsqlTest.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPTManyToManyQueryNpgsqlFixture.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPTManyToManyNoTrackingQueryNpgsqlTest.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPTInheritanceTableSplittingQueryNpgsqlTest.cs | Adds Npgsql table-splitting coverage for TPT inheritance. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPTInheritanceQueryNpgsqlTest.cs | Adds full Npgsql-specific TPT inheritance test baselines (replacing removed stub). |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPTInheritanceQueryNpgsqlFixture.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPTInheritanceJsonQueryNpgsqlTest.cs | Adds Npgsql JSON baselines for TPT inheritance complex type scenarios. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPTInheritanceJsonQueryNpgsqlFixture.cs | Adds fixture for TPT inheritance JSON query tests. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPTGearsOfWarQueryNpgsqlTest.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPTGearsOfWarQueryNpgsqlFixture.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPTFiltersInheritanceQueryNpgsqlTest.cs | Adds corrected Npgsql filters inheritance test class under new namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPTFiltersInheritanceQueryNpgsqlFixture.cs | Adds corrected Npgsql filters inheritance fixture under new namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPHInheritanceTableSplittingQueryNpgsqlTest.cs | Adds Npgsql table-splitting coverage for TPH inheritance. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPHInheritanceQueryNpgsqlTest.cs | Adds full Npgsql-specific TPH inheritance test baselines (replacing removed stub). |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPHInheritanceQueryNpgsqlFixture.cs | Moves to ...Query.Inheritance and tweaks raw SQL mapping call formatting. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPHInheritanceJsonQueryNpgsqlTest.cs | Adds JSON baselines for TPH inheritance. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPHInheritanceJsonQueryNpgsqlFixture.cs | Adds fixture for TPH inheritance JSON query tests. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPHFiltersInheritanceQueryNpgsqlFixture.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPCRelationshipsQueryNpgsqlTest.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPCManyToManyQueryNpgsqlTest.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPCManyToManyQueryNpgsqlFixture.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPCManyToManyNoTrackingQueryNpgsqlTest.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPCInheritanceTableSplittingQueryNpgsqlTest.cs | Adds Npgsql table-splitting coverage for TPC inheritance. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPCInheritanceQueryNpgsqlFixture.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPCInheritanceJsonQueryNpgsqlTest.cs | Adds JSON baselines for TPC inheritance. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPCInheritanceJsonQueryNpgsqlFixture.cs | Adds fixture for TPC inheritance JSON query tests. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPCGearsOfWarQueryNpgsqlTest.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPCGearsOfWarQueryNpgsqlFixture.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPCFiltersInheritanceQueryNpgsqlTest.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/Inheritance/TPCFiltersInheritanceQueryNpgsqlFixture.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/FiltersInheritanceQueryNpgsqlTest.cs | Moves to ...Query.Inheritance namespace. |
| test/EFCore.PG.FunctionalTests/Query/EntitySplittingQueryNpgsqlTest.cs | Adds overridden baseline for split-entity null comparison. |
| test/EFCore.PG.FunctionalTests/Query/ComplexTypeQueryNpgsqlTest.cs | Updates baselines for complex-type equality and parameter naming. |
| test/EFCore.PG.FunctionalTests/Query/Associations/OwnedTableSplitting/OwnedTableSplittingMiscellaneousNpgsqlTest.cs | Adds FromSql_on_root override + baseline. |
| test/EFCore.PG.FunctionalTests/Query/Associations/OwnedNavigations/OwnedNavigationsMiscellaneousNpgsqlTest.cs | Adds FromSql_on_root override + baseline. |
| test/EFCore.PG.FunctionalTests/Query/Associations/OwnedNavigations/OwnedNavigationsCollectionNpgsqlTest.cs | Adds Index_on_nested_collection override with empty baseline. |
| test/EFCore.PG.FunctionalTests/Query/Associations/OwnedJson/OwnedJsonMiscellaneousNpgsqlTest.cs | Adds FromSql_on_root override + baseline. |
| test/EFCore.PG.FunctionalTests/Query/Associations/OwnedJson/OwnedJsonCollectionNpgsqlTest.cs | Adds Index_on_nested_collection override + baseline. |
| test/EFCore.PG.FunctionalTests/Query/Associations/Navigations/NavigationsMiscellaneousNpgsqlTest.cs | Adds FromSql_on_root override + baseline. |
| test/EFCore.PG.FunctionalTests/Query/Associations/Navigations/NavigationsCollectionNpgsqlTest.cs | Adds Index_on_nested_collection override with empty baseline. |
| test/EFCore.PG.FunctionalTests/Query/Associations/ComplexTableSplitting/ComplexTableSplittingStructuralEqualityNpgsqlTest.cs | Updates structural equality SQL baselines and parameter baselines. |
| test/EFCore.PG.FunctionalTests/Query/Associations/ComplexTableSplitting/ComplexTableSplittingMiscellaneousNpgsqlTest.cs | Adds FromSql_on_root override + baseline. |
| test/EFCore.PG.FunctionalTests/Query/Associations/ComplexTableSplitting/ComplexTableSplittingBulkUpdateNpgsqlTest.cs | Updates bulk update/delete SQL baselines and parameter baselines. |
| test/EFCore.PG.FunctionalTests/Query/Associations/ComplexJson/ComplexJsonStructuralEqualityNpgsqlTest.cs | Updates JSON structural equality parameter baselines. |
| test/EFCore.PG.FunctionalTests/Query/Associations/ComplexJson/ComplexJsonMiscellaneousNpgsqlTest.cs | Adds FromSql_on_root override asserting exception + empty baseline. |
| test/EFCore.PG.FunctionalTests/Query/Associations/ComplexJson/ComplexJsonCollectionNpgsqlTest.cs | Updates index parameter baseline and adds Index_on_nested_collection baseline. |
| test/EFCore.PG.FunctionalTests/Query/Associations/ComplexJson/ComplexJsonBulkUpdateNpgsqlTest.cs | Updates JSON bulk update/delete baselines and parameter baselines. |
| test/EFCore.PG.FunctionalTests/Query/AdHocJsonQueryNpgsqlTest.cs | Disables EF8001 warning for obsolete ToJson usage. |
| test/EFCore.PG.FunctionalTests/Query/AdHocComplexTypeQueryNpgsqlTest.cs | Switches base class to relational variant; removes SQL Server-specific override and local AssertSql helpers. |
| test/EFCore.PG.FunctionalTests/CustomConvertersNpgsqlTest.cs | Removes some skipped overrides and associated model seeding adjustments (EF11 sync). |
| test/EFCore.PG.FunctionalTests/ConvertToProviderTypesNpgsqlTest.cs | Removes some skipped overrides and associated model seeding adjustments (EF11 sync). |
| test/EFCore.PG.FunctionalTests/BulkUpdates/TPTInheritanceBulkUpdatesNpgsqlTest.cs | Adds using for relocated inheritance bulk update base types. |
| test/EFCore.PG.FunctionalTests/BulkUpdates/TPTInheritanceBulkUpdatesNpgsqlFixture.cs | Adds using for relocated inheritance bulk update base types. |
| test/EFCore.PG.FunctionalTests/BulkUpdates/TPTFiltersInheritanceBulkUpdatesNpgsqlTest.cs | Adds using for relocated inheritance bulk update base types (but class naming needs correction). |
| test/EFCore.PG.FunctionalTests/BulkUpdates/TPTFiltersInheritanceBulkUpdatesNpgsqlFixture.cs | Adds using for relocated inheritance bulk update base types. |
| test/EFCore.PG.FunctionalTests/BulkUpdates/TPHInheritanceBulkUpdatesNpgsqlTest.cs | Adds using and updates parameter naming in SQL baselines. |
| test/EFCore.PG.FunctionalTests/BulkUpdates/TPHInheritanceBulkUpdatesNpgsqlFixture.cs | Adds using for relocated inheritance bulk update base types. |
| test/EFCore.PG.FunctionalTests/BulkUpdates/TPHFiltersInheritanceBulkUpdatesNpgsqlTest.cs | Adds using and updates parameter naming in SQL baselines. |
| test/EFCore.PG.FunctionalTests/BulkUpdates/TPHFiltersInheritanceBulkUpdatesNpgsqlFixture.cs | Adds using for relocated inheritance bulk update base types. |
| test/EFCore.PG.FunctionalTests/BulkUpdates/TPCInheritanceBulkUpdatesNpgsqlTest.cs | Adds using and updates parameter naming in SQL baselines. |
| test/EFCore.PG.FunctionalTests/BulkUpdates/TPCInheritanceBulkUpdatesNpgsqlFixture.cs | Adds using for relocated inheritance bulk update base types. |
| test/EFCore.PG.FunctionalTests/BulkUpdates/TPCFiltersInheritanceBulkUpdatesNpgsqlTest.cs | Adds using and updates parameter naming in SQL baselines. |
| test/EFCore.PG.FunctionalTests/BulkUpdates/TPCFiltersInheritanceBulkUpdatesNpgsqlFixture.cs | Adds using for relocated inheritance bulk update base types. |
| test/EFCore.PG.FunctionalTests/BulkUpdates/NorthwindBulkUpdatesNpgsqlTest.cs | Updates parameter naming and adds new update-related baselines. |
| test/EFCore.PG.FunctionalTests/BulkUpdates/NonSharedModelBulkUpdatesNpgsqlTest.cs | Adds missing SQL baselines for view-mapped complex type updates and repositions override-check test. |
| test/EFCore.PG.FunctionalTests/BuiltInDataTypesNpgsqlTest.cs | Removes large blocks of overrides/seeding previously used for DateTimeOffset limitations (EF11 sync). |
| global.json | Updates pinned .NET SDK version. |
| NuGet.config | Switches mapped feed from dotnet10 to dotnet11. |
| Directory.Packages.props | Updates EF Core / Microsoft.Extensions package versions to EF11 preview and applies property-based version range. |
| Directory.Build.props | Updates target framework to net11.0 and version prefix to 11.0.0-preview.1. |
Comments suppressed due to low confidence (1)
test/EFCore.PG.FunctionalTests/BulkUpdates/TPTFiltersInheritanceBulkUpdatesNpgsqlTest.cs:7
- The class in this Npgsql test file is named TPTFiltersInheritanceBulkUpdatesSqlServerTest even though it uses the Npgsql fixture/base types. This mismatch is confusing and makes it harder to locate/understand provider-specific tests.
Rename the class to TPTFiltersInheritanceBulkUpdatesNpgsqlTest (and update the primary constructor accordingly) so the type name matches the file/provider.
public class TPTFiltersInheritanceBulkUpdatesSqlServerTest(
TPTFiltersInheritanceBulkUpdatesNpgsqlFixture fixture,
ITestOutputHelper testOutputHelper)
: TPTFiltersInheritanceBulkUpdatesTestBase<TPTFiltersInheritanceBulkUpdatesNpgsqlFixture>(fixture, testOutputHelper)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
2
to
6
| "sdk": { | ||
| "version": "10.0.100", | ||
| "version": "11.0.100-preview.1.26104.118", | ||
| "rollForward": "latestMinor", | ||
| "allowPrerelease": false | ||
| "allowPrerelease": true | ||
| } |
There was a problem hiding this comment.
global.json pins the SDK to 10.0.103 with allowPrerelease=false, but the repo now targets net11.0 (Directory.Build.props) and EFCore 11.0.0-preview packages. This combination is very likely to fail builds/restore because the pinned SDK may not support targeting net11.0 and prerelease tooling.
Consider updating the pinned SDK version to the appropriate 11.x SDK and/or setting allowPrerelease=true so the configured TargetFramework and preview dependencies can be built consistently.
Comment on lines
3
to
5
| public class NpgsqlBoolTypeTest(NpgsqlBoolTypeTest.DateOnlyTypeFixture fixture, ITestOutputHelper testOutputHelper) | ||
| : RelationalTypeTestBase<DateOnly, NpgsqlBoolTypeTest.DateOnlyTypeFixture>(fixture, testOutputHelper) | ||
| { |
There was a problem hiding this comment.
This file defines a DateOnly type test, but the test class is named NpgsqlBoolTypeTest (and the generic/fixture types reference NpgsqlBoolTypeTest). This looks like a copy/paste error and makes the test suite confusing to navigate/discover.
Rename the class (and nested fixture references) to NpgsqlDateOnlyTypeTest to match the file name and the tested CLR type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.