Skip to content

Improved metabase interfaces for group-addressed operations #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roman-khimov merged 3 commits into from
Apr 14, 2026

metabase: adjust GetGarbage interface to simplify GC

9bbbf09
Select commit
Loading
Failed to load commit list.
Merged

Improved metabase interfaces for group-addressed operations #3933

metabase: adjust GetGarbage interface to simplify GC
9bbbf09
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 14, 2026 in 1s

26.78% (-0.05%) compared to 543f7cd, passed because coverage increased by 0.13% when compared to adjusted base (26.65%)

View this Pull Request on Codecov

26.78% (-0.05%) compared to 543f7cd, passed because coverage increased by 0.13% when compared to adjusted base (26.65%)

Details

Codecov Report

❌ Patch coverage is 62.85714% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.78%. Comparing base (543f7cd) to head (9bbbf09).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-lancet/internal/meta/remove.go 0.00% 22 Missing ⚠️
pkg/local_object_storage/metabase/inhume.go 67.64% 7 Missing and 4 partials ⚠️
pkg/local_object_storage/shard/gc.go 57.69% 7 Missing and 4 partials ⚠️
pkg/local_object_storage/metabase/delete.go 77.77% 5 Missing and 1 partial ⚠️
pkg/local_object_storage/engine/inhume.go 71.42% 4 Missing ⚠️
pkg/local_object_storage/metabase/graveyard.go 80.95% 3 Missing and 1 partial ⚠️
pkg/local_object_storage/engine/delete.go 50.00% 2 Missing ⚠️
pkg/local_object_storage/shard/delete.go 83.33% 2 Missing ⚠️
pkg/local_object_storage/engine/put.go 0.00% 1 Missing ⚠️
pkg/local_object_storage/shard/inhume.go 85.71% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3933      +/-   ##
==========================================
- Coverage   26.83%   26.78%   -0.05%     
==========================================
  Files         670      670              
  Lines       44372    44360      -12     
==========================================
- Hits        11906    11884      -22     
- Misses      31355    31365      +10     
  Partials     1111     1111

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov