Skip to content

yt-dlp download progress - #2227

Merged
nukeop merged 12 commits into
masterfrom
fix/ytdlp-first-download
Oct 17, 2026
Merged

nukeop merged 12 commits into
masterfrom
fix/ytdlp-first-download

Conversation

@nukeop

@nukeop nukeop commented Oct 16, 2026

Copy link
Copy Markdown
Owner

No description provided.

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 1.42kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
player-esm 17.29MB 1.42kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: player-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/initPlayerApp-*.js 1.11kB 918.02kB 0.12%
assets/src-*.js 314 bytes 332.23kB 0.09%

Files in assets/initPlayerApp-*.js:

  • ./src/services/tauri/commands.ts → Total Size: 435 bytes

  • ./changelog.json → Total Size: 21.88kB

  • ./src/initPlayerApp.tsx → Total Size: 1.34kB

  • ./src/hooks/useYtdlpDownload.ts → Total Size: 1.72kB

  • ./src/App.tsx → Total Size: 643 bytes

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.63%. Comparing base (4ac3be7) to head (e00c9e3).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
packages/player/src/hooks/useYtdlpDownload.ts 96.96% 0 Missing and 1 partial ⚠️

❌ Your project check has failed because the head coverage (65.78%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2227      +/-   ##
==========================================
+ Coverage   84.57%   84.63%   +0.06%     
==========================================
  Files         623      624       +1     
  Lines        7878     7910      +32     
  Branches     1482     1486       +4     
==========================================
+ Hits         6663     6695      +32     
+ Misses        820      819       -1     
- Partials      395      396       +1     
Flag Coverage Δ
unittests 84.63% <97.05%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Player (App) 87.39% <97.05%> (+0.08%) ⬆️
UI Library 80.04% <ø> (ø)
Hifi 82.63% <ø> (ø)
Data Model 69.84% <ø> (ø)
Plugin SDK ∅ <ø> (∅)
Themes 65.78% <ø> (ø)

@nukeop
nukeop merged commit 5fec2c9 into master Oct 17, 2026
22 checks passed
@nukeop
nukeop deleted the fix/ytdlp-first-download branch October 17, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant